Yamls for JPSSRR sea-ice obs in cycling test #1300
Conversation
apchoiCMD
requested review from
guillaumevernieres,
givelberg,
AndrewEichmann-NOAA,
KatherineLukens-NOAA and
JohnSteffen-NOAA
| minvalue: 0.0 | ||
| maxvalue: 1.0 | ||
| #- filter: Background Check | ||
| # threshold: 5.0 |
There was a problem hiding this comment.
Do we need to keep this background check filter commented out? If not, then delete.
There was a problem hiding this comment.
Good point but now as same as what amsr2 has
| minvalue: 0.0 | ||
| maxvalue: 1.0 | ||
| #- filter: Background Check | ||
| # threshold: 5.0 |
There was a problem hiding this comment.
Same comment as the *north.yaml
There was a problem hiding this comment.
the same answer above
| maxvalue: 1.0 | ||
| #- filter: Background Check | ||
| # threshold: 5.0 | ||
| - filter: Domain Check |
There was a problem hiding this comment.
Why is there a domain check for sea_surface_temperature > 2.0 and also > 0? Isn't one sufficient?
| @@ -15,6 +15,8 @@ observers: | |||
| # Ice concentration | |||
| - !INC ${MARINE_OBS_YAML_DIR}/icec_amsr2_north.yaml | |||
| - !INC ${MARINE_OBS_YAML_DIR}/icec_amsr2_south.yaml | |||
| #- !INC ${MARINE_OBS_YAML_DIR}/icec_viirs_n20_l2_north.yaml | |||
There was a problem hiding this comment.
Did you mean to comment this out? Same question for "south"
There was a problem hiding this comment.
Not part of CI yet, we will need to comment out when we have to use them-
|
Does the figure above has all the obs for the cycle? If so, there's probably a bug somewhere @apchoiCMD . |
This PR is to add the yaml keys
NHandSH, please see inyamlsandobsprep_config.yamlRelated to #1259